Conversation
Previously, the scip-java Bazel support only supported SimpleFileObject in the Java compiler API and it crashed when encountering other types of file objects like DirectoryFileObject, which are used in some Bazel builds in the wild. This commit adds support for DirectoryFileObject. Additionally, this commit adds more detailed documentation on how to use scip-java with Bazel.
keynmol
approved these changes
Jun 15, 2023
Strum355
reviewed
Jun 15, 2023
| throw new IllegalArgumentException("unsupported source file: " + toString); | ||
| // The Bazel Java compiler constructs `SimpleFileObject/DirectoryFileObject` with a | ||
| // "user-friendly" name that points to the original source file and an underlying/actual | ||
| // file path in a temporary directory. We're constrained by having to use only public APIs of |
Contributor
There was a problem hiding this comment.
We're constrained by having to use only public APIs of the Java compiler
Is this a bazel restriction? I dont think this is true for scip-java, we almost definitely use non public parts
Contributor
Author
There was a problem hiding this comment.
Not a bazel restriction. We try to limit non-public API usage as much as possible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the scip-java Bazel support only supported SimpleFileObject in the Java compiler API and it crashed when encountering other types of file objects like DirectoryFileObject, which are used in some Bazel builds in the wild. This commit adds support for DirectoryFileObject.
Additionally, this commit adds more detailed documentation on how to use scip-java with Bazel.
Test plan
Green CI.
Manually tested there was no regression in the steps below