Auto build tool - choose the first one that applies#582
Merged
Conversation
olafurpg
approved these changes
May 10, 2023
| usedBuildTools.map(_.name) | ||
| ) match { | ||
| case Some(closest) => | ||
| s"Did you mean --build-tool=$closest?" |
Contributor
There was a problem hiding this comment.
Minor: the indentation is getting so deep it might make sense to move logic into a helper method.
Contributor
Author
There was a problem hiding this comment.
Yeah, will refactor.
| new MillBuildTool(index) | ||
| ) | ||
|
|
||
| def autoOrdered(index: IndexCommand): List[BuildTool] = |
Contributor
There was a problem hiding this comment.
Is there a reason we can't make the all() method return popularity-ordered build tools?
Contributor
Author
There was a problem hiding this comment.
Bazel being a supported (but not supported?) auto tool is one reason - but I can just implement one method in terms of the other if you think it'll be clearer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To simplify the inference rules, we are providing
--build-tool=automode which selects first matching tool from a list.The list itself is ordered by relative popularity according to Jetbrains' surveys likethis: https://www.jetbrains.com/lp/devecosystem-2022/scala/#which-build-systems-do-you-regularly-use-if-any-
Test plan
N/A