Merged
Conversation
olafurpg
approved these changes
Apr 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been seeing lots of issues with
plugin/compilenot working - even on a clean machine.It'd work once, and then next invocation crashes:
If one takes a look at the debug output, it's clear that for some reason

javacOptionshave changed between runs:Randomly thrashing about I ended up removing the
javaHomefrom per-configuration settings, to the global one.Immediately I was successful in running
plugin/compilemultiple times without issue, along with rerunning tests without having to constantly clear the cache.I cannot explain it, nor am I sure that this is the fix, but it's a pretty strong signal on my machine that this change fixes one of the issues I was having.
Test plan
CI shouldn't be affected by this change, manual testing confirms some improvements.