WIP: Fix gradle tool to work with Gradle 8.0+#549
Closed
Conversation
olafurpg
reviewed
Apr 14, 2023
| case None => | ||
| "" | ||
| s""" | ||
| options.annotationProcessorPath = files('$pluginpath') |
Contributor
There was a problem hiding this comment.
How does this interoperate with other annotation processors in the build?
Contributor
Author
There was a problem hiding this comment.
I will verify, and possibly just append the plugin to existing paths, instead of overriding the entire path.
|
|
||
| val javacModuleOptions = | ||
| if (toolchains.isJavaAtLeast(9)) | ||
| List( |
Contributor
There was a problem hiding this comment.
This list is available in BuildInfo.javacModuleOptions if you .map(_.stripPrefix("-J"))
Contributor
Author
There was a problem hiding this comment.
Nice!
The current problem is that the time at which this check is run is not right - I need to replicate it in the gradle script
Contributor
Author
|
Superseded by #565 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows the tests progress further, but something is still missing
Test plan