Publish separate scip-java-proto artifact with scip.proto generated classes#523
Merged
Publish separate scip-java-proto artifact with scip.proto generated classes#523
Conversation
…lasses Fixes #522 Previously, it was necessary to generate classes from the scip.proto source if you wanted to write Java tooling that consumes SCIP. This commit reorganizes the build so that we publish a new com.sourcegraph:scip-java-proto artifact that only includes the generated protobuf classes from scip.proto. Note that we don't guarantee binary compatibility for public classes in this module.
Strum355
approved these changes
Nov 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #522
Previously, it was necessary to generate classes from the scip.proto source if you wanted to write Java tooling that consumes SCIP. This commit reorganizes the build so that we publish a new
com.sourcegraph:scip-java-proto artifact that only includes the generated protobuf classes from scip.proto. Note that we don't guarantee binary compatibility for public classes in this module.
Test plan
See the CI go live. I ran
sbt scipProto/publishLocaland verified that the published artifact has minimal classes and minimal dependencies.Details
The protobuf dependencies are unavoidable.
Details