dep: bump scalapb related stuff#487
Merged
olafurpg merged 1 commit intosourcegraph:mainfrom Aug 17, 2022
Merged
Conversation
This is an attempt to try to better align the protoc related tooling since we've bumped the version of protobuf in the main build, but also have older transitive stuff that is being brought in by these. Probably best to bump them as well. Sort of an attempt to see what might be going on with sourcegraph#486.
Contributor
Author
Any idea why it still thinks I'm a first-time contributor? |
olafurpg
approved these changes
Aug 17, 2022
Contributor
|
I also opened #488, which should probably fix the underlying issue, but it's good to perform this upgrade nevertheless.
I have no idea why I need to repeatedly press this button 🤷 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to try to better align the protoc related tooling
since we've bumped the version of protobuf in the main build, but also
have older transitive stuff that is being brought in by these. Probably
best to bump them as well.
Sort of an attempt to see what might be going on with
#486.
Test plan
Tests should just remain 🟢