Use a better Java package name for generated Protobuf classes#458
Merged
Use a better Java package name for generated Protobuf classes#458
Conversation
varungandhi-src
approved these changes
Jun 9, 2022
olafurpg
commented
Jun 9, 2022
Contributor
Author
olafurpg
left a comment
olafurpg
left a comment
There was a problem hiding this comment.
It may seem problematic that this repo has a modified copy of the original scip.proto but it's not really an issue IMO. We can fix more stuff later but right I just want to stop generating code to the lib.codeintel.scip package.
olafurpg
force-pushed
the
olafurpg/scip-package
branch
from
0365985 to
e14f629
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test plan
See the CI go green.