Automate Docker container build and fix Java version detection#372
Merged
olafurpg merged 1 commit intosourcegraph:mainfrom Nov 22, 2021
Merged
Automate Docker container build and fix Java version detection#372olafurpg merged 1 commit intosourcegraph:mainfrom
olafurpg merged 1 commit intosourcegraph:mainfrom
Conversation
Previously, the Docker release process was manual. Now, the Docker container is built by sbt on CI release and pushed to Docker Hub. Also, the Docker container previously used the default Java version to launch `lsif-java`. This caused problems in cases where the sources of the project would be compiled with a different Java version from the version that's specified in `dump.lsif`. Now, the LSIF version should always match the version that was used to compile the sources.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the Docker release process was manual. Now, the Docker
container is built by sbt on CI release and pushed to Docker Hub.
Also, the Docker container previously used the default Java version (8) to
launch
lsif-java. This caused problems in projects using a non-default versionbecause the sources of the project would be compiled with the correct version (non-8)
but the
dump.lsifversion would specify Java 8. Now, the version indump.lsifshouldalways match the version that was used to compile the sources.