Skip to content

add emitting of type parameters in method signatures #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Strum355 merged 1 commit into from
Mar 26, 2021
Merged

add emitting of type parameters in method signatures #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions semanticdb-javac/src/main/java/com/sourcegraph/semanticdb_javac/SemanticdbVisitor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,17 @@ public Void visitMethod(MethodTree node, Void unused) {
range = CompilerRange.FROM_TEXT_SEARCH;
}
emitSymbolOccurrence(meth.sym, meth, Role.DEFINITION, range);

List<JCTree.JCTypeParameter> typeParameters = meth.getTypeParameters();
int i = 0;
for (Symbol.TypeVariableSymbol typeSym : meth.sym.getTypeParameters()) {
emitSymbolOccurrence(
typeSym,
typeParameters.get(i),
Role.DEFINITION,
CompilerRange.FROM_POINT_TO_SYMBOL_NAME);
i++;
}
}
return super.visitMethod(node, unused);
}
Expand Down
2 changes: 2 additions & 0 deletions tests/snapshots/src/main/generated/com/airbnb/epoxy/EpoxyTouchHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,7 @@ private DragBuilder3(EpoxyController controller, RecyclerView recyclerView, int
* draggable type.
*/
public <U extends EpoxyModel> DragBuilder4<U> withTarget(Class<U> targetModelClass) {
// ^ definition com/airbnb/epoxy/EpoxyTouchHelper#DragBuilder3#withTarget().[U]
// ^^^^^^^^^^ reference com/airbnb/epoxy/EpoxyModel#
// ^^^^^^^^^^^^ reference com/airbnb/epoxy/EpoxyTouchHelper#DragBuilder4#
// ^ reference com/airbnb/epoxy/EpoxyTouchHelper#DragBuilder3#withTarget().[U]
Expand Down Expand Up @@ -737,6 +738,7 @@ private SwipeBuilder2(RecyclerView recyclerView,
* swipable type.
*/
public <U extends EpoxyModel> SwipeBuilder3<U> withTarget(Class<U> targetModelClass) {
// ^ definition com/airbnb/epoxy/EpoxyTouchHelper#SwipeBuilder2#withTarget().[U]
// ^^^^^^^^^^ reference com/airbnb/epoxy/EpoxyModel#
// ^^^^^^^^^^^^^ reference com/airbnb/epoxy/EpoxyTouchHelper#SwipeBuilder3#
// ^ reference com/airbnb/epoxy/EpoxyTouchHelper#SwipeBuilder2#withTarget().[U]
Expand Down
2 changes: 2 additions & 0 deletions tests/snapshots/src/main/generated/minimized/InnerClasses.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,8 @@ public Integer apply(Integer integer) {
}

private static <A, B> B runInnerInterface(InnerInterface<A, B> fn, A a) {
// ^ definition minimized/InnerClasses#runInnerInterface().[A]
// ^ definition minimized/InnerClasses#runInnerInterface().[B]
// ^ reference minimized/InnerClasses#runInnerInterface().[B]
// ^^^^^^^^^^^^^^^^^ definition minimized/InnerClasses#runInnerInterface().
// ^^^^^^^^^^^^^^ reference minimized/InnerClasses#InnerInterface#
Expand Down
1 change: 1 addition & 0 deletions tests/snapshots/src/main/generated/minimized/TypeVariables.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ public void mI() {}
}

public static <T extends C & I> void app(T t) {
// ^ definition minimized/TypeVariables#app().[T]
// ^ reference minimized/TypeVariables#C#
// ^ reference minimized/TypeVariables#I#
// ^^^ definition minimized/TypeVariables#app().
Expand Down