Skip to content
This repository was archived by the owner on Feb 22, 2020. It is now read-only.

feat: support custom initializationOptions #36

Merged
merged 1 commit into from
May 14, 2019

Conversation

chrismwendt
Copy link
Contributor

This lets consumers provide custom initializationOptions for all workspaces.

This subsumes #11 which included workarounds for go-langserver prior to sourcegraph/go-langserver#373

@codecov-io
Copy link

Codecov Report

Merging #36 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #36   +/-   ##
=======================================
  Coverage   65.18%   65.18%           
=======================================
  Files          11       11           
  Lines         293      293           
  Branches       20       20           
=======================================
  Hits          191      191           
  Misses        102      102
Impacted Files Coverage Δ
src/index.ts 62.04% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e394a11...3d60ad3. Read the comment docs.

@chrismwendt chrismwendt merged commit 50948a2 into master May 14, 2019
@chrismwendt chrismwendt deleted the custom-initialization-options branch May 14, 2019 23:49
@chrismwendt
Copy link
Contributor Author

@felixfbecker Do I need to bump the beta branch to trigger CI to make a release?

@felixfbecker
Copy link
Contributor

yep

@sourcegraph-bot
Copy link

🎉 This PR is included in version 1.1.0-beta.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@chrismwendt
Copy link
Contributor Author

1.1.0-beta.2 doesn't seem right. The latest is 2.0.0-beta.1. Is there another branch I need to update?

@felixfbecker
Copy link
Contributor

That's weird indeed. Will investigate

@felixfbecker
Copy link
Contributor

@felixfbecker
Copy link
Contributor

I released 2.0.0-beta.2 manually

@chrismwendt
Copy link
Contributor Author

Ok, thanks. I'm seeing a source map warning, not sure if it's related:

[serve] ⚠️ Could not load source file "../../src/features/feature.ts" in source map of "../node_modules/@sourcegraph/lsp-client/dist/features/feature.js".

@felixfbecker
Copy link
Contributor

Well sources are not published nor inlined, but that doesn't sound related to the release issue?

@chrismwendt
Copy link
Contributor Author

Gotcha, yeah it's not related.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants