Skip to content

Fix WebUIService creation issue due to disposed project #2608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

mkondratek
Copy link
Contributor

@mkondratek mkondratek commented Nov 8, 2024

Fixes https://linear.app/sourcegraph/issue/BUGS-693/webuiservice-initialization-issue-due-to-the-disposed-project.

Test plan

During initialization of the project (during the indexing):
Close / open project. Switch projects.

@mkondratek mkondratek self-assigned this Nov 8, 2024
@mkondratek mkondratek changed the title Remove StubWebviewProvider Fix WebUIService creation issue due to disposed project Nov 8, 2024
Copy link
Contributor

@pkukielka pkukielka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkondratek mkondratek merged commit 283374a into main Nov 12, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants