Skip to content

Fix Container is already disposed from withAgent #2597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

mkondratek
Copy link
Contributor

@mkondratek mkondratek commented Nov 7, 2024

We received multiple reports of #2517.
This PR fixes #2517.

Test plan

I was not able to reproduce it. I tried closing and opening the project quickly. Tried switching projects too. No success.

@mkondratek mkondratek self-assigned this Nov 7, 2024
@mkondratek mkondratek changed the title Remove redundant methods Fix Container is already disposed from withAgent Nov 7, 2024
This was referenced Nov 7, 2024
This was referenced Nov 7, 2024
) {
if (CodyApplicationSettings.instance.isCodyEnabled) {
ApplicationManager.getApplication().executeOnPooledThread {
try {
if (project.isDisposed) return@executeOnPooledThread
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the fix

@mkondratek mkondratek enabled auto-merge (squash) November 7, 2024 22:15
Copy link
Contributor

@pkukielka pkukielka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkondratek mkondratek merged commit 417444a into main Nov 8, 2024
12 of 13 checks passed
@mkondratek mkondratek deleted the mkondratek/fix/disposed-error branch November 8, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: com.intellij.serviceContainer.AlreadyDisposedException: Container is already disposed
2 participants