Fix plugin name in the marketplace #2586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkondratek
reviewed
Nov 6, 2024
| @@ -1,7 +1,7 @@ | |||
| # IntelliJ Platform Artifacts Repositories | |||
| # -> https://plugins.jetbrains.com/docs/intellij/intellij-artifacts.html | |||
| pluginGroup=com.sourcegraph.jetbrains | |||
| pluginName=Sourcegraph | |||
| pluginName=Cody: AI Coding Assistant with Autocomplete & Chat | |||
There was a problem hiding this comment.
I was thinking about it too 😅
There is a logical inconsistency with this change. The plugin is not only about Cody but Code Search too.
Our description looks like this (it is defined in the marketplace settings):
I think this change should be approved by someone else (marketing team?).
There was a problem hiding this comment.
I copied plugin name from plugin.xml where it was approved, this is most likely regression from IJ plugin 2.0 migration.
And name was changed intentionally some time ago:
9761f25
There was a problem hiding this comment.
we'll make a decision to deprecate the code search part, its legacy
mkondratek
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test plan
Settings > Plugins