Improve logging cody debug messages #2583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkondratek
approved these changes
Nov 5, 2024
pkukielka
added a commit
to sourcegraph/cody-public-snapshot
that referenced
this pull request
Nov 6, 2024
## Changes Fixes logging capability in agent. Previously messages logged to output channel were visible only if added using `append` or `appendLine`. Now `trace` / `debug` / `info` / `warn` / `error` functions are also logged properly. ## Test plan As in sourcegraph/jetbrains#2583
pkukielka
force-pushed
the
pkukielka/improve-cody-logging
branch
from
3d9b9f5 to
5169bd0
Compare
kalanchan
pushed a commit
that referenced
this pull request
Nov 8, 2024
Fixes https://linear.app/sourcegraph/issue/QA-149 ## Chnages Adds detailed Cody logging, e.g. network errors. Required dev mode (e.g. `:customRunIde`) or debug logging enabled in settings for trace/debug/info messages, errors and warning are logged always. Cody Console is popping out only in dev mode regardless of the message severity. ## Test plan 1. Run `:customRunIde` - there is good chance you will notice some network errors at the start, but there should not be much of them 2. Go to the Cody settings and enable debug logging. 3. Restart IDE 4. Now you should see much more debug messages in Cody Console and in the logs 
Merged
kalanchan
added a commit
that referenced
this pull request
Nov 8, 2024
cherry pick #2583 - allowing flexibility as we didn't inform the team on branch cut deadlines Fixes https://linear.app/sourcegraph/issue/QA-149 ## Chnages Adds detailed Cody logging, e.g. network errors. Required dev mode (e.g. `:customRunIde`) or debug logging enabled in settings for trace/debug/info messages, errors and warning are logged always. Cody Console is popping out only in dev mode regardless of the message severity. ## Test plan 1. Run `:customRunIde` - there is good chance you will notice some network errors at the start, but there should not be much of them 2. Go to the Cody settings and enable debug logging. 3. Restart IDE 4. Now you should see much more debug messages in Cody Console and in the logs  ## Test plan <!-- All pull requests REQUIRE a test plan: https://sourcegraph.com/docs/dev/background-information/testing_principles Why does it matter? These test plans are there to demonstrate that are following industry standards which are important or critical for our customers. They might be read by customers or an auditor. There are meant be simple and easy to read. Simply explain what you did to ensure your changes are correct! Here are a non exhaustive list of test plan examples to help you: - Making changes on a given feature or component: - "Covered by existing tests" or "CI" for the shortest possible plan if there is zero ambiguity - "Added new tests" - "Manually tested" (if non trivial, share some output, logs, or screenshot) - Updating docs: - "previewed locally" - share a screenshot if you want to be thorough - Updating deps, that would typically fail immediately in CI if incorrect - "CI" - "locally tested" --> Co-authored-by: Piotr Kukiełka <pkukielka@users.noreply.github.com>
PriNova
pushed a commit
to PriNova/cody
that referenced
this pull request
Nov 8, 2024
## Changes Fixes logging capability in agent. Previously messages logged to output channel were visible only if added using `append` or `appendLine`. Now `trace` / `debug` / `info` / `warn` / `error` functions are also logged properly. ## Test plan As in sourcegraph/jetbrains#2583
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://linear.app/sourcegraph/issue/QA-149
Chnages
Adds detailed Cody logging, e.g. network errors.
Required dev mode (e.g.
:customRunIde) or debug logging enabled in settings for trace/debug/info messages,errors and warning are logged always. Cody Console is popping out only in dev mode regardless of the message severity.
Test plan
:customRunIde- there is good chance you will notice some network errors at the start, but there should not be much of them