Skip to content

Make sure we are logging cody debug messages when debug logging is enabled #2550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

pkukielka
Copy link
Contributor

Test plan

  1. Run IntelliJ using :customRunIde and make sure cody logs are present in the idea.log
  2. Run normal IntelliJ instance with verbose logging DISABLED and make sure cody logs are NOT present in the idea.log
  3. Run normal IntelliJ instance with verbose logging ENABLED and make sure cody logs are present in the idea.log

return Optional.ofNullable(isCodyDebugEnabled).orElse(false);
}

public boolean isCodyVerboseDebugEnabled() {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed all those were not used anymore.

@pkukielka pkukielka force-pushed the pkukielka/improve-logging branch from 0ce7b7d to 4ceda95 Compare October 31, 2024 15:50
@pkukielka pkukielka merged commit 6cac3bd into main Oct 31, 2024
9 of 12 checks passed
@pkukielka pkukielka deleted the pkukielka/improve-logging branch October 31, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants