Fix threading issues with showDocument #2431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkukielka
reviewed
Oct 10, 2024
| val selection = params.options?.selection | ||
| val preserveFocus = params.options?.preserveFocus | ||
| CodyEditorUtil.showDocument(project, vf, selection, preserveFocus) | ||
| true |
There was a problem hiding this comment.
We can delate that true as it is incorrect, showDocument already returns true if it succeeded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2151.
The problem was that the descriptors constructor needs to be called in BGT while ::navigate requires EDT.
Test plan
A good approach to test it is to verify all code paths. There are three: