This repository was archived by the owner on Oct 16, 2020. It is now read-only.
fix(imports): stop using import assignment (for ECMAScript modules) #480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #480 +/- ##
=======================================
Coverage 83.08% 83.08%
=======================================
Files 15 15
Lines 2052 2052
Branches 420 487 +67
=======================================
Hits 1705 1705
Misses 345 345
Partials 2 2
Continue to review full report at Codecov.
|
| import { castArray, merge, omit } from 'lodash' | ||
| import { toPairs } from 'lodash' | ||
| import hashObject = require('object-hash') | ||
| import * as hashObject from 'object-hash' |
Contributor
There was a problem hiding this comment.
Using * as for functions that are exported with module.exports is not semantically correct - according to the ES6 spec hashObject would be a frozen module record object, not a function.
The right solution for this would be to use the new esModuleInterop flag and import the default import.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to compile as ECMAScript modules, errors about import assignment don't allow compilation. This pull request fixes that by changing such to use
import * as XXX from YYYinstead.