type resolution does not pick up type packages that are installed in parent directories

[despairblue]

I'm using javascript-typescript-langserver in atom via ide-typescript.

The module resolution does not seem to pick up types that are installed in parent directories. This happens usually in monorepos when common dependencies get hoisted to the top level's node_module folder.

I made a repro repo. The file imports debug, but debug ist installed to directories further up the dir tree:

.
├── node_modules
│   ├── .yarn-integrity
│   ├── @types
│   │   ├── debug
│   │   │   ├── LICENSE
│   │   │   ├── README.md
│   │   │   ├── index.d.ts                 <-- Definition 
│   │   │   └── package.json
│   │   └── node
│   │       ├── LICENSE
│   │       ├── README.md
│   │       ├── index.d.ts
│   │       ├── inspector.d.ts
│   │       └── package.json
│   ├── debug
│   │   ├── .coveralls.yml
│   │   ├── .eslintrc
│   │   ├── .npmignore
│   │   ├── .travis.yml
│   │   ├── CHANGELOG.md
│   │   ├── LICENSE
│   │   ├── Makefile
│   │   ├── README.md
│   │   ├── component.json
│   │   ├── karma.conf.js
│   │   ├── node.js
│   │   ├── package.json
│   │   └── src
│   │       ├── browser.js
│   │       ├── debug.js
│   │       ├── index.js
│   │       └── node.js
│   └── ms
│       ├── index.js
│       ├── license.md
│       ├── package.json
│       └── readme.md
├── package.json
├── packages
│   └── main
│       ├── node_modules
│       │   ├── .bin
│       │   ├── .yarn-integrity
│       │   └── typescript
│       ├── package.json
│       ├── src
│       │   ├── test.js
│       │   └── test.ts                   <-- importing dependency
│       ├── tsconfig.json
│       ├── yarn-error.log
│       └── yarn.lock
└── yarn.lock

Using tsc to commpile it works find: npm run build.

[felixfbecker]

What folder did you open as rootUri? Does it work in tsserver / VS Code?

[tomv564]

If rootUri was '.' (not 'packages') then the hoisted declaration files would be visible to the language server.

But this restriction in globalTSPatterns would likely filter it out: https://github.com/sourcegraph/javascript-typescript-langserver/blob/master/src/util.ts#L121

[felixfbecker]

I don't think so as @types/debug is probably not used as a global module

[despairblue]

I open the whole repository. We have a monorepo at work. It does work with atom-typescript. Which I think starts the tsserver with the first folder it finds containing a tsconfig (when recursively looking for one starting from the folder the source file is in) as the root dir. I can try what happens when I open it in vscode tomorrow.

[tomv564]

I tried your repo with the (for now unmerged) typescript 2.4.2 branch:

• String enums were parsed correctly with this update.
• The debug import also works (at least, I get typed hovers and no diagnostics).
  You could test by updating ide-typescript's dependency to tomv564/javascript-typescript-langserver#upgrade-to-typescript-2.4.2.

The debug import does cause a (handled) error:

javascript-typescript-stdio: Error resolving file references for file:///Users/tomv/Projects/temp/ide-typescript-test/broken1/packages/main/src/test.ts: Error: TypeScript config file for /Users/tomv/Projects/temp/ide-typescript-test/broken1/node_modules/@types/debug/index.d.ts not found from rootPath /Users/tomv/Projects/temp/ide-typescript-test/broken1
    at ProjectManager.getConfiguration (/Users/tomv/Projects/sourcegraph/javascript-typescript-langserver/lib/project-manager.js:303:19)
    at DeferSubscriber.observable.updater.ensure.concat.rxjs_1.Observable.defer [as factory] (/Users/tomv/Projects/sourcegraph/javascript-typescript-langserver/lib/project-manager.js:263:33)

This is caused by any package registration removing the default root configs, even if those new packages are found in subfolders.
Changing trimmedRootPath to dir in

javascript-typescript-langserver/src/project-manager.ts

Line 173 in 6087974

if (configs.get(trimmedRootPath) === fallbackConfigs[configType]) {

might fix this?

[despairblue]

@tomv564 I just tried it and everything works. Thank you.

The debug import does cause a (handled) error:
...

I don't understand enough about the codebase to understand what's happening there 😄
I just tried to get ide-typescript to start the server with --inspect but failed.
I may retry later, but for now everything seems to work. Thank you for that. 👏

[despairblue]

Or actually it does work for my repro repo, but not in my repo I'm working in currently. I'll try to update the repro case.

When I open a file it does not find the dependency, after a while it then does...I keep an eye on this and try to find a pattern.

[keyboardDrummer]

I think this is a related issue.

[cmatzenbach]

I had an issue with lsp not being able to find typescript definition files for includes in my projet, and it made it unusable with that giant error popping up every second. @tomv564's little fix works perfectly - should this be sent in a PR, or is there a reason for not including it?