Skip to content
This repository was archived by the owner on Oct 16, 2020. It is now read-only.
This repository was archived by the owner on Oct 16, 2020. It is now read-only.

Make code more resolved around URIs, not file paths #106

Open

Description

@felixfbecker

LSP uses URIs to identify files. The LS uses file paths almost exclusively. This makes it impossible to, for example, to identify files that are not saved yet in the editor. It is not guaranteed that a URI can always be translated to a file path.

The TS language service probably only works with paths, but that translation should happen as late as possible, not as early as possible. In practice this means methods should take URIs where possible and classes like InMemoryFileSystem must be able to save files by URI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions