[Backport 6.5.x] Fix(release): promoteToPublic.finalize github:pr update main target bug #287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ug (#286) Closes REL-1069 ## Problem The release pipeline has been systematically failing in the `promoteToPublic.finalize` workflow with this error: ``` Warning: 1 uncommitted change must be on a branch named differently than 'promote/release-v6.4.3889-update-main' ``` ## Root Cause The final `github:pr` step in the `promoteToPublic.finalize` workflow was incorrectly trying to create a PR from the current branch to itself: - **Current branch**: `promote/release-{{version}}-update-main` - **Target branch**: `promote/release-{{version}}-update-main` ❌ (same branch!) - **Should target**: `main` ✅ This happened because the variable `internal_branch` was set to the current branch name instead of the intended target branch. ### Test plan This will have to be tested on a release (cherry picked from commit 61f4376)
jdpleiness
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes REL-1069
Problem
The release pipeline has been systematically failing in the
promoteToPublic.finalizeworkflow with this error:Root Cause
The final
github:prstep in thepromoteToPublic.finalizeworkflow was incorrectly trying to create a PR from the current branch to itself:promote/release-{{version}}-update-mainpromote/release-{{version}}-update-main❌ (same branch!)main✅This happened because the variable
internal_branchwas set to the current branch name instead of the intended target branch.Test plan
This will have to be tested on a release
Backport 61f4376 from #286