Default to latest Sourcegraph release (3.36.2) #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No significant changes for this release, version bump only
caugustus-sourcegraph
requested review from
filiphaftek,
michaellzc and
kevinwojo
michaellzc
approved these changes
Jan 28, 2022
|
just curious, is this a manual change or it was done by batch change? |
|
@michaellzc - I ran a local script that pulls the images from the release branches in the deploy repos 😅 I haven't checked it in because it's a temporary hack and not for anyone to use. This project is still in beta and hasn't yet been incorporated into the batch changes functionality. The tricky part is that the batch changes ultimately rely on https://github.com/sourcegraph/update-docker-tags, which only works against full image references. The values.yaml doesn't expose the full image directly so we need to make some code changes to support the new use case. That work isn't yet planned but it will be required soon. |
michaellzc
added a commit
that referenced
this pull request
Jan 25, 2025
…afana sts (#628) regression from #617 it's now rendering `_SSLMODE` twice in the grafana sts ### Checklist - [ ] Follow the [manual testing process](https://github.com/sourcegraph/deploy-sourcegraph-helm/blob/main/TEST.md) - [ ] Update [changelog](https://github.com/sourcegraph/deploy-sourcegraph-helm/blob/main/charts/sourcegraph/CHANGELOG.md) - [ ] Update [Kubernetes update doc](https://docs.sourcegraph.com/admin/updates/kubernetes) ### Test plan CI <br> Backport bb2d4f1 from #627 Co-authored-by: Michael Lin <mlzc@hey.com>
Chickensoupwithrice
added a commit
that referenced
this pull request
Feb 19, 2025
The start of a resolution for [REL-690](https://linear.app/sourcegraph/issue/REL-690/add-runasuser-runasgroup-fsgroup-to-executor-helm-chart). Need to test this out to see how it works. There are sample overrides in [this thread](https://sourcegraph.slack.com/archives/C0418GDBT7S/p1738581012896529?thread_ts=1738580801.517539&cid=C0418GDBT7S) ### Checklist - [x] Follow the [manual testing process](https://github.com/sourcegraph/deploy-sourcegraph-helm/blob/main/TEST.md) - [ ] Update [changelog](https://github.com/sourcegraph/deploy-sourcegraph-helm/blob/main/charts/sourcegraph/CHANGELOG.md) - [ ] Update [Kubernetes update doc](https://docs.sourcegraph.com/admin/updates/kubernetes) ### Test plan Run the example overrides from the thread and see if the executor runs and doesn't fail. In particular we want a _named_ user that is not privileged. <br> Backport 45e5817 from #632 Co-authored-by: Anish Lakhwara <anish+github@lakhwara.com>
DaedalusG
added a commit
that referenced
this pull request
Jun 25, 2025
…ate main target bug (#702) Closes REL-1068 ## Problem The release pipeline has been systematically failing in the `promoteToPublic.finalize` workflow with this error: ``` Warning: 1 uncommitted change must be on a branch named differently than 'promote/release-v6.4.3889-update-main' ``` ## Root Cause The final `github:pr` step in the `promoteToPublic.finalize` workflow was incorrectly trying to create a PR from the current branch to itself: - **Current branch**: `promote/release-{{version}}-update-main` - **Target branch**: `promote/release-{{version}}-update-main` ❌ (same branch!) - **Should target**: `main` ✅ This happened because the variable `internal_branch` was set to the current branch name instead of the intended target branch. ### Test plan This will have to be tested on a release <br> Backport 1c06d26 from #699 Co-authored-by: Warren Gifford <warrenbruceg@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No significant changes for this release, version bump only