Skip to content

[Backport 6.5.x] Fix(release): promoteToPublic.finalize github:pr update main target bug #1231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 6.5.x
Choose a base branch
from
Open

[Backport 6.5.x] Fix(release): promoteToPublic.finalize github:pr update main target bug #1231

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,13 +278,11 @@ promoteToPublic:
- name: "github:pr"
cmd: |
set -eu
internal_branch="promote/release-{{version}}-update-main"
# we need to fetch from origin just in case this branch doesn't exist locally, so that the PR can find the base
git fetch origin "${internal_branch}"
# Create PR to merge release updates into main branch
gh pr create \
--fill \
--draft \
--base "$internal_branch" \
--base main \
--title "Update main: build {{version}}" \
--body "Test plan: automated release PR, CI will perform additional checks"
echo "🚢 Please check the associated CI build to ensure the process completed".