fix(chat): check storage size for chat history #7958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abeatrix
reviewed
May 20, 2025
There was a problem hiding this comment.
instead of removing the chat history automatically, should we show a banner and ask users to remove / export their chat history themselves?
#7953 (comment)
| } | ||
| } | ||
|
|
||
| console.log(`Trimming ${oldestChats.length} old chat conversations to reduce storage size`) |
There was a problem hiding this comment.
Suggested change
| console.log(`Trimming ${oldestChats.length} old chat conversations to reduce storage size`) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implemented automatic chat history cleanup that removes oldest conversations when storage exceeds STORAGE_SIZE_BIG. Uses an optimized algorithm to identify and trim the oldest chats while preserving newer conversations. Added constants to make the threshold and number of chats to remove configurable.
Right now
STORAGE_SIZE_BIGis set to 50k KB, andNUM_CHATS_TO_TRIM(the maximum number of chats to trim) is set to 5.Test plan
Tested locally.
Have at least 6 conversations in the chat history. Change STORAGE_SIZE_BIG to a small number (ex: 5000) and check if the chat gets deleted once the storage size is too big.