This repository was archived by the owner on Nov 25, 2021. It is now read-only.
fix: unsubscribe from actions and hover observable #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only take from the actions and hover Observables until the code view is unsubscribed. Fixes https://github.com/sourcegraph/sourcegraph/issues/3108
chrismwendt
approved these changes
Apr 1, 2019
Codecov Report
@@ Coverage Diff @@
## master #102 +/- ##
==========================================
- Coverage 83.77% 83.71% -0.07%
==========================================
Files 13 13
Lines 524 528 +4
Branches 120 120
==========================================
+ Hits 439 442 +3
- Misses 85 86 +1
Continue to review full report at Codecov.
|
|
🎉 This PR is included in version 6.0.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #100
The code view was still possible to be re-shown after being hidden because the nested action and hover Observables were not unsubscribed from and could emit after the code view was unhoverified. This would happen on a page navigation, because the removed code view causes the text documents in the extension API to be updated, which causes the Observable returned by
getActionsto emit again.The test reproduces the problem by making
getActionsemit something.The fix is to use
takeUntil()to only take from the actions and hover Observables until the code view is unsubscribed (we need to do this for the two higher-order Observables).Fixes https://github.com/sourcegraph/sourcegraph/issues/3108