Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(chore): fix sonar code smells #59

Merged
merged 1 commit into from
Apr 19, 2023
Merged

fix(chore): fix sonar code smells #59

merged 1 commit into from
Apr 19, 2023

Conversation

RaghavaroraSF
Copy link
Contributor

@RaghavaroraSF RaghavaroraSF commented Apr 19, 2023 •
edited by shubhamp-sf
Loading

Description

  • Resolving sonar code smells to improve quality gate

Fixes #52

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Intermediate change (work in progress)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Any dependent changes have been merged and published in downstream modules

@RaghavaroraSF
fix(chore): fix sonar code smells
c03d68a 
Resolving sonar code smells to improve quality gate

GH-52
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@shubhamp-sf shubhamp-sf merged commit 7405662 into master Apr 19, 2023
@shubhamp-sf shubhamp-sf deleted the GH-52 branch April 19, 2023 13:32
@shubhamp-sf
Copy link
Contributor

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubhamp-sf shubhamp-sf shubhamp-sf approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Sonar Quality Gate
2 participants
@RaghavaroraSF @shubhamp-sf