Skip to content

Breadcrumbs feature #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Breadcrumbs feature #129

wants to merge 2 commits into from

Conversation

Tyagi-Sunny
Copy link
Contributor

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Intermediate change (work in progress)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Any dependent changes have been merged and published in downstream modules

- Implemented a new Breadcrumbs component for enhanced navigation.
- Added dynamic and static breadcrumb examples in the demo component.
- Updated routing to include breadcrumb data for user and note details.
- Modified app-routing and main-routing modules to integrate breadcrumbs.
- Included new SVG assets for breadcrumbs in the project.

This enhances user experience by providing clear navigation paths throughout the application.
@rohit-sourcefuse rohit-sourcefuse marked this pull request as draft June 10, 2025 12:00
@rohit-sourcefuse rohit-sourcefuse requested a review from Copilot June 10, 2025 12:03
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements the Breadcrumbs feature and integrates it into the existing application along with demo and test components. Key changes include:

  • Adding the BreadcrumbsComponent as a standalone component into various modules.
  • Introducing dynamic breadcrumb demo routes (with resolvers) in the introduction routing.
  • Creating supporting services, tests, and documentation for breadcrumb functionality.

Reviewed Changes

Copilot reviewed 25 out of 25 changed files in this pull request and generated no comments.

Show a summary per file
File Description
projects/arc/src/app/main/introduction/introduction.module.ts Imports BreadcrumbsComponent and refactors component declarations for standalone usage.
projects/arc/src/app/main/introduction/introduction.component.ts Updates component logic for route changes by subscribing to router events.
projects/arc/src/app/main/introduction/introduction.component.html Wraps content conditionally based on the existence of child routes.
projects/arc/src/app/main/introduction/introduction-routing.module.ts Adds breadcrumb demo routes with resolvers to demonstrate dynamic breadcrumb behavior.
projects/arc/src/app/main/constants/components.constant.ts Adds a new menu item for the Breadcrumbs feature.
projects/arc/src/app/app-routing.module.ts Updates RouterModule configuration with anchorScrolling enabled and comments out AuthGuard for demo purposes.
projects/arc-lib/src/lib/core/breadcrumb.service.ts Implements the core logic for building breadcrumb trails.
projects/arc-lib/src/lib/components/breadcrumbs/* Introduces the BreadcrumbsComponent along with demo, tests, styles, and examples.
Comments suppressed due to low confidence (2)

projects/arc/src/app/main/introduction/introduction.component.ts:26

  • Consider consolidating the duplicate subscriptions to router.events to avoid redundant calls to loadConfig and simplify the component logic.
ngOnInit() { ...

projects/arc-lib/src/lib/components/breadcrumbs/breadcrumbs-demo.component.ts:63

  • Consider unsubscribing from the router.events subscription (e.g., using takeUntil or the AsyncPipe) to prevent potential memory leaks.
this.router.events.subscribe(() => { ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants