-
Notifications
You must be signed in to change notification settings - Fork 106
Config format V2 #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Config format V2 #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a8004bb
to
0793668
Compare
brendan-kellam
commented
Oct 17, 2024
brendan-kellam
commented
Oct 17, 2024
msukkari
reviewed
Oct 17, 2024
msukkari
previously approved these changes
Oct 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥🔥🔥 tested working on my side (public/private github and gitlab, as well as self-hosted gitlab)
… cloning)" This reverts commit cb085b8.
… in 'configs/' directory
6298924
to
540054e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new configuration schema that is more expressive.
Example config:
With the new configuration schema comes a new index server, located in
packages/backend
. This has the same functionality aszoekt-indexserver
(it will clone repos and periodically re-index them), but with improved logging s.t., it's now easier to determine what the index server is doing.Fixes #35
Fixes #27