-
Notifications
You must be signed in to change notification settings - Fork 106
[selection] highlight clarity #342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[selection] highlight clarity #342
Conversation
WalkthroughA new section was added to the changelog to document a fix for improved text highlighting clarity. Corresponding CSS changes were made to enhance selection background and foreground colors in the code editor and content areas, including dark mode support. No changes were made to exported or public entities. Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
479ba29
to
dd0eb5c
Compare
dd0eb5c
to
514b06f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/web/src/app/globals.css (1)
256-262
: Define and centralize selection highlight variables for maintainability
The new rules rely solely on fallback values; declaring--editor-selection-highlight
and--editor-selection-highlight-foreground
in:root
and under.dark
would centralize customization and make future tweaks easier.@layer base { :root { + --editor-selection-highlight: #ffe066; + --editor-selection-highlight-foreground: #222; } .dark { + --editor-selection-highlight: #2563eb; + --editor-selection-highlight-foreground: #fff; } }Also applies to: 264-269
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
CHANGELOG.md
(1 hunks)packages/web/src/app/globals.css
(1 hunks)
🧰 Additional context used
🪛 LanguageTool
CHANGELOG.md
[uncategorized] ~15-~15: Possible missing comma found.
Context: ...ot-dev/sourcebot/pull/341) ### Fixed - Text highlighting clarity. [#342](https://gi...
(AI_HYDRA_LEO_MISSING_COMMA)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build
🔇 Additional comments (1)
CHANGELOG.md (1)
14-15
: Changelog entry looks good
The “Fixed” section and its bullet correctly capture the text highlighting clarity improvement introduced in PR #342.🧰 Tools
🪛 LanguageTool
[uncategorized] ~15-~15: Possible missing comma found.
Context: ...ot-dev/sourcebot/pull/341) ### Fixed - Text highlighting clarity. [#342](https://gi...(AI_HYDRA_LEO_MISSING_COMMA)
I prefer the way I defined from a readability perspective but I don't feel strongly. |
Awesome! Do you mind attaching screenshots for dark + light? |
See updated description! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 thanks!
light
+dark
mode.Summary by CodeRabbit
Bug Fixes
Documentation