Skip to content

[selection] highlight clarity #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025

Conversation

drew-u410
Copy link
Contributor

@drew-u410 drew-u410 commented Jun 10, 2025

  • [Fix] When selecting text the highlighting is not visible. This adds coloring to the highlight to make it clear in both light + dark mode.
Old New
Screenshot 2025-06-10 at 11 48 39 AM Screenshot 2025-06-10 at 11 49 14 AM
Screenshot 2025-06-10 at 11 48 48 AM Screenshot 2025-06-10 at 11 49 21 AM

Summary by CodeRabbit

  • Bug Fixes

    • Improved text highlighting clarity in the code editor and general content areas, including enhanced selection colors for both light and dark modes.
  • Documentation

    • Updated the changelog to document the text highlighting fix.

Copy link

coderabbitai bot commented Jun 10, 2025

Walkthrough

A new section was added to the changelog to document a fix for improved text highlighting clarity. Corresponding CSS changes were made to enhance selection background and foreground colors in the code editor and content areas, including dark mode support. No changes were made to exported or public entities.

Changes

File(s) Change Summary
CHANGELOG.md Added a "Fixed" section under "Unreleased" for improved text highlighting clarity (PR #342).
packages/web/src/app/globals.css Updated selection background/foreground styles for code editor and content, including dark mode.

Poem

In the garden of code, selections now gleam,
With colors that shimmer, a coder’s dream.
From changelog to style, the fix is in place,
Highlighting clarity—no more chase!
In light and in dark, the hues never hide,
A rabbit’s delight, with CSS as its guide.
🐇✨


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@drew-u410 drew-u410 force-pushed the drew/select_coloring branch from 479ba29 to dd0eb5c Compare June 10, 2025 15:41
@drew-u410 drew-u410 force-pushed the drew/select_coloring branch from dd0eb5c to 514b06f Compare June 10, 2025 15:42
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
packages/web/src/app/globals.css (1)

256-262: Define and centralize selection highlight variables for maintainability
The new rules rely solely on fallback values; declaring --editor-selection-highlight and --editor-selection-highlight-foreground in :root and under .dark would centralize customization and make future tweaks easier.

@layer base {
  :root {
+   --editor-selection-highlight: #ffe066;
+   --editor-selection-highlight-foreground: #222;
  }
  .dark {
+   --editor-selection-highlight: #2563eb;
+   --editor-selection-highlight-foreground: #fff;
  }
}

Also applies to: 264-269

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1d3d028 and 514b06f.

📒 Files selected for processing (2)
  • CHANGELOG.md (1 hunks)
  • packages/web/src/app/globals.css (1 hunks)
🧰 Additional context used
🪛 LanguageTool
CHANGELOG.md

[uncategorized] ~15-~15: Possible missing comma found.
Context: ...ot-dev/sourcebot/pull/341) ### Fixed - Text highlighting clarity. [#342](https://gi...

(AI_HYDRA_LEO_MISSING_COMMA)

⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: build
🔇 Additional comments (1)
CHANGELOG.md (1)

14-15: Changelog entry looks good
The “Fixed” section and its bullet correctly capture the text highlighting clarity improvement introduced in PR #342.

🧰 Tools
🪛 LanguageTool

[uncategorized] ~15-~15: Possible missing comma found.
Context: ...ot-dev/sourcebot/pull/341) ### Fixed - Text highlighting clarity. [#342](https://gi...

(AI_HYDRA_LEO_MISSING_COMMA)

@drew-u410
Copy link
Contributor Author

Actionable comments posted: 0

🧹 Nitpick comments (1)
📜 Review details

I prefer the way I defined from a readability perspective but I don't feel strongly.

@brendan-kellam
Copy link
Contributor

Awesome! Do you mind attaching screenshots for dark + light?

@drew-u410
Copy link
Contributor Author

Awesome! Do you mind attaching screenshots for dark + light?

See updated description!

Copy link
Contributor

@brendan-kellam brendan-kellam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 thanks!

@brendan-kellam brendan-kellam merged commit 9be5522 into sourcebot-dev:main Jun 10, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants