Align gitea clone_url with gitea host url. Addresses #270

[securisec]

This PR aligns gitea cloneUrl with hostUrl. When gitea is deployed as part of a docker-compose stack, it will incorrectly get the cloneUrl from the gitea API which will indicate localhost which is not correct. This will case sourcebot to fail when cloning the repo.

This fix ensures that the user specified host url is always used when cloning repos also. Addresses #270

Summary by CodeRabbit

• Bug Fixes
  • Improved consistency of repository clone URLs by ensuring their host matches the configured host URL for Gitea repositories.

[coderabbitai]

Walkthrough

The compileGiteaConfig function in the backend utility was updated to ensure that repository clone URLs have their host component replaced with the host from a configured URL. This is achieved by creating and manipulating URL objects for both the configuration and each repository's clone URL.

Changes

File(s)	Change Summary
packages/backend/src/repoCompileUtils.ts	Modified compileGiteaConfig to replace the host in each repository's clone URL with the host from the configured URL using URL object manipulation. No other logic or signature changes.

Poem

In the garden of code, a host hops anew,
URLs realigned, like morning dew.
Each repo’s address, now tidy and neat,
Gitea’s connections skip to the beat.
A rabbit’s delight in a patch so small—
One clever hop, improving all! 🐇🌱

Tip

⚡️ Faster reviews with caching

• CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (2)

packages/backend/src/repoCompileUtils.ts (2)

185-231: Consider adding error handling for URL parsing

While the implementation is correct, the code doesn't handle potential URL parsing errors that could occur if either hostUrl or repo.clone_url is malformed.

Consider adding error handling around the URL creation:

  const repos = giteaRepos.map((repo) => {
-       const configUrl = new URL(hostUrl);
-       const cloneUrl = new URL(repo.clone_url!);
-       cloneUrl.host = configUrl.host
+       try {
+           const configUrl = new URL(hostUrl);
+           const cloneUrl = new URL(repo.clone_url!);
+           cloneUrl.host = configUrl.host;
+           
+           const repoDisplayName = repo.full_name!;
+           const repoName = path.join(repoNameRoot, repoDisplayName);
+
+           logger.debug(`Found gitea repo ${repoDisplayName} with webUrl: ${repo.html_url}`);
+
+           // Rest of the code...
+       } catch (error) {
+           logger.error(`Failed to process Gitea repo: ${repo.full_name}`, error);
+           throw new Error(`Invalid URL format for Gitea repository: ${error.message}`);
+       }

---

186-187: Consider adding a debug log for clone URL changes

Adding a debug log statement would help when troubleshooting URL transformation issues in the future.

  const configUrl = new URL(hostUrl);
  const cloneUrl = new URL(repo.clone_url!);
+ logger.debug(`Replacing Gitea clone URL host from ${cloneUrl.host} to ${configUrl.host}`);
  cloneUrl.host = configUrl.host

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 53a9308 and 74bdf92.

📒 Files selected for processing (1)

• packages/backend/src/repoCompileUtils.ts (1 hunks)

[msukkari]

Thanks!