Skip to content

Add type annotations and static type checks #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 23, 2020
Merged

Add type annotations and static type checks #78

merged 7 commits into from
Sep 23, 2020

Conversation

chrissimpkins
Copy link
Member

@chrissimpkins chrissimpkins commented Sep 22, 2020 •
edited
Loading

This PR adds:

  • type annotations to all Python source files
  • updates type check approach from pytype to mypy tool
  • updates dev dependencies to include mypy, remove pytype
  • refactor import statement sorting with isort default format

TODO

  • add GH Action configuration for mypy type checks in GH Action CI (307cba6)

Closes #77

@chrissimpkins chrissimpkins merged commit b80c6af into master Sep 23, 2020
@chrissimpkins chrissimpkins deleted the static-type-checks branch September 23, 2020 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add static type checks
1 participant
@chrissimpkins