Skip to content

Add glyphs U+012C..U+012D #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2017

Conversation

mynetx
Copy link
Contributor

@mynetx mynetx commented Sep 29, 2017

bildschirmfoto 2017-09-29 um 21 55 20

bildschirmfoto 2017-09-29 um 21 56 10

bildschirmfoto 2017-09-29 um 21 56 35

bildschirmfoto 2017-09-29 um 21 57 21

@mynetx
Copy link
Contributor Author

mynetx commented Sep 29, 2017

@chrissimpkins I did not touch the metadata – please advise if you’re going to do that on your own.

@chrissimpkins
Copy link
Member

No problem JM, I can definitely take care of the metadata. Thanks for adding these glyphs!

Associated issue report for missing glyphs in the Latin Ext A set: #324

@chrissimpkins chrissimpkins added this to the v3.0 milestone Sep 29, 2017
@chrissimpkins
Copy link
Member

chrissimpkins commented Sep 29, 2017

@jublo out of interest, did you modify the design in a different directory or add the plist files to .gitignore?

@mynetx
Copy link
Contributor Author

mynetx commented Sep 30, 2017

@chrissimpkins I added the glyphs like always, and from the list of changed files, I discarded anything except those new files.

@mynetx mynetx force-pushed the feature/glyphs-012c-012d branch from df6587a to 90d910d Compare September 30, 2017 11:26
@mynetx
Copy link
Contributor Author

mynetx commented Sep 30, 2017

Fixed horizontal position of the breve on lowercase letter in Regular now.

@mynetx mynetx force-pushed the feature/glyphs-012c-012d branch from 90d910d to 6e0572c Compare September 30, 2017 11:36
@mynetx
Copy link
Contributor Author

mynetx commented Sep 30, 2017

Renamed files to their correct names.

@chrissimpkins
Copy link
Member

chrissimpkins commented Sep 30, 2017

I discarded anything except those new files

Like this?

$ git add *.glif
$ git commit -m "message"
$ git push

Or did you manually revert the plist files that editor changed?

Trying to come up with a PR workflow that is simple and does not modify the plist XML files

@mynetx
Copy link
Contributor Author

mynetx commented Sep 30, 2017

I took a look at the changed files in SmartGit, like this:

bildschirmfoto 2017-09-30 um 14 09 50

Then I would select anything except the glif file.

bildschirmfoto 2017-09-30 um 14 10 27

And finally commit the remaining file.

@chrissimpkins
Copy link
Member

so you just work in a dirty repository with the plist modifications that happen with the edits and do not commit those?

@mynetx
Copy link
Contributor Author

mynetx commented Sep 30, 2017

@chrissimpkins That's right.

@chrissimpkins
Copy link
Member

merged into dev-latin-a branch. will merge to dev once we have tests passing. Need the regular variant glyphs for ebreve / Ebreve before we can complete the build to confirm.

@chrissimpkins chrissimpkins merged commit 6e0572c into source-foundry:dev Oct 3, 2017
@chrissimpkins
Copy link
Member

tests passed. merged to dev

@mynetx mynetx deleted the feature/glyphs-012c-012d branch October 5, 2017 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants