Skip to content

Conversation

@mug1wara26
Copy link
Collaborator

Implementation for #11

@heyzec
Copy link
Collaborator

heyzec commented Jun 26, 2025

@mug1wara26 Could you help with the merge conflicts?

@mug1wara26
Copy link
Collaborator Author

strange i removed the conflict markers using the github editor but it didnt actually remove them

@martin-henz martin-henz requested a review from shirsho-12 June 27, 2025 05:08
@heyzec
Copy link
Collaborator

heyzec commented Jun 29, 2025

Can you help take a look into this again? I tried changing to Chapter to 4, but it is sending the updated info to the LSP, but the error message still shows, saying that list is not defined (Source 1)

@mug1wara26
Copy link
Collaborator Author

Can you help take a look into this again? I tried changing to Chapter to 4, but it is sending the updated info to the LSP, but the error message still shows, saying that list is not defined (Source 1)

I'm unable to reproduce this issue, could you test it again?

output.mp4

@RichDom2185
Copy link
Member

Hi, any update on this PR?

@mug1wara26
Copy link
Collaborator Author

When I last tested it still worked for me, I can work on resolving merge conflicts during the weekend

@RichDom2185
Copy link
Member

When I last tested it still worked for me, I can work on resolving merge conflicts during the weekend

Great, thanks a lot! I think if we can push out an update it would be good and also prevent confusion

@mug1wara26
Copy link
Collaborator Author

Hi @RichDom2185 I fixed the merge conflicts and it seems to be working on my end, switching the chapter on the playground updates the LSP, and diagnostics appear/disappear immediately. Could you test it out too to make sure it works on your end as well?

@mug1wara26
Copy link
Collaborator Author

mug1wara26 commented Sep 8, 2025

Since Source 2 is being taught right now, I'll merge this so that the students can test it out
@RichDom2185 could you approve the PR 😅

@mug1wara26 mug1wara26 enabled auto-merge (squash) September 8, 2025 18:00
@mug1wara26 mug1wara26 disabled auto-merge September 8, 2025 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants