Migrate to Vitest, TypeScript 5.9, NodeJS 22 #1815
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # package.json # src/parser/__tests__/disallowed-syntax.test.ts # src/repl/utils.ts # src/utils/operators.ts # tsconfig.json # yarn.lock
…nto vitest-testing-refactor
This reverts commit 4390454.
RichDom2185
approved these changes
Nov 4, 2025
Comment on lines
+80
to
+81
| // TODO: The snapshots just never match for whatever reason | ||
| describe.skip('Test output options', () => { |
| @@ -1,5 +1,7 @@ | |||
| // TODO: Convert to actual benchmark | |||
| @@ -1,4 +1,6 @@ | |||
| #!/usr/bin/env node | |||
| /* istanbul ignore file */ | |||
There was a problem hiding this comment.
Aren't we using v8 instead of istanbul for coverage?
There was a problem hiding this comment.
I can't figure out why snapshots are not generated for this file (and also svmc.test.ts when I unskip locally). But it's minor and can always fix later.
This reverts commit 2f072b3.
RichDom2185
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate to Vitest
Following the modules repo and frontend, this PR migrates the repository to Vitest. I've tried to minimize changes where possible since Vitest was designed as a drop in for Jest, but unlike Jest Vitest requires calls to
toMatchInlineSnapshotto be directly fromexpect.Relocation of Enums
The Chapter, Variant, ErrorType and ErrorSeverity enums needed to be relocated to other files to allow Vitest to actually work. I suspect it has something to do with the circular imports that aren't just elided during runtime.
I'm not sure if they should be re-exported through the
types.tsfile though.