Setup ECE - Evaluate LocalVariableDeclarationStatement #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xyliew25
requested review from
1001mei and
bryanlohxz
and removed request for
1001mei
1001mei
reviewed
Sep 26, 2023
bryanlohxz
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the ECE logic is referenced from js-slang.
Due to the limitation of the java-parser library used, expressions such as
1 + 2 * 3are not parsed with the appropriate precedence of multiplicative operations over additive operations. Hence, some post-processing is done to encode the appropriate precedence. As a result, both types of expression such as1 + 2 * 3and1 + (2 * 3)are evaluated correctly.