Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More features on compiler #18

Merged
merged 19 commits into from
Mar 13, 2024
Merged

More features on compiler #18

merged 19 commits into from
Mar 13, 2024

Conversation

1001mei
Copy link
Contributor

@1001mei 1001mei commented Feb 12, 2024

No description provided.

@1001mei 1001mei marked this pull request as ready for review March 11, 2024 13:59
@1001mei 1001mei requested review from xyliew25 and bryanlohxz March 11, 2024 16:39
xyliew25
xyliew25 reviewed Mar 12, 2024
View reviewed changes
Copy link
Contributor

@xyliew25 xyliew25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I know if it is intended that new constructs are added but not actually extracted?

@1001mei
Copy link
Contributor Author

1001mei commented Mar 13, 2024

May I know if it is intended that new constructs are added but not actually extracted?

Yes, for example the import declarations are added to the AST structure without being extracted. I intend to create a separate PR for the extraction part. The idea is that we could settle on the AST structure and resolve existing build errors in the repo first. This could reduce the dependencies between components.

@xyliew25 xyliew25 self-requested a review March 13, 2024 07:08
@1001mei 1001mei merged commit b9ee945 into main Mar 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xyliew25 xyliew25 xyliew25 approved these changes

@bryanlohxz bryanlohxz Awaiting requested review from bryanlohxz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@1001mei @xyliew25