Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add jvm instruction tests #15

Merged
merged 13 commits into from
Feb 15, 2024
Merged

Add jvm instruction tests #15

merged 13 commits into from
Feb 15, 2024

Conversation

Chang-CH
Copy link
Contributor

  • Unit test cases for JVM instructions
  • Add monitor for concurrency support

@Chang-CH Chang-CH requested a review from 1001mei January 21, 2024 11:19
@Chang-CH Chang-CH changed the title Jvm instruction tests Add jvm instruction tests Jan 21, 2024
1001mei
1001mei approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@1001mei 1001mei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are well organized and comprehensive. Other changes look good overall. LGTM.

@Chang-CH Chang-CH merged commit 3201473 into main Feb 15, 2024
2 checks passed
@Chang-CH Chang-CH deleted the jvm-test branch April 9, 2024 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1001mei 1001mei 1001mei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Chang-CH @1001mei