Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: classfile representation #1

Merged
merged 8 commits into from
Sep 13, 2023
Merged

feat: classfile representation #1

merged 8 commits into from
Sep 13, 2023

Conversation

Chang-CH
Copy link
Contributor

No description provided.

@Chang-CH Chang-CH requested a review from 1001mei September 10, 2023 07:50
Copy link
Contributor

@1001mei 1001mei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the types and constants for ClassFile, the overall structure is very clean.

An alternative way to organize the files is as follows.

ClassFile/
  |_constants/
  |_types/

Since the AST part might also has its constants and types, I feel like organizing them this way gives better separation and fewer confusions since different parts can work on different top level folder.

@Chang-CH
Copy link
Contributor Author

Thanks for adding the types and constants for ClassFile, the overall structure is very clean.

An alternative way to organize the files is as follows.

ClassFile/
  |_constants/
  |_types/

Since the AST part might also has its constants and types, I feel like organizing them this way gives better separation and fewer confusions since different parts can work on different top level folder.

Refactored.

@bryanlohxz
Copy link
Contributor

So sorry, but can we place the ClassFile overarching folder under the src directory?

@1001mei
Copy link
Contributor

1001mei commented Sep 12, 2023

Ya, sure!

@1001mei 1001mei merged commit 38b85c2 into main Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants