-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: classfile representation #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the types and constants for ClassFile, the overall structure is very clean.
An alternative way to organize the files is as follows.
ClassFile/
|_constants/
|_types/
Since the AST part might also has its constants and types, I feel like organizing them this way gives better separation and fewer confusions since different parts can work on different top level folder.
Refactored. |
So sorry, but can we place the |
Ya, sure! |
No description provided.