Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bumping js-slang #2885

Merged
merged 8 commits into from
Mar 29, 2024
Merged

bumping js-slang #2885

merged 8 commits into from
Mar 29, 2024

Conversation

martin-henz
Copy link
Member

@martin-henz martin-henz commented Mar 28, 2024

See: source-academy/js-slang#1600

Fixes #2700
Fixes #2705
Fixes #2781
This might solve #2716, but unable to test due to issue #2883.

Changes

  • Any object created in the stash now also appear inside the environment, next to the correct frame
  • Revamp removePreludeEnv() behavior, it now completely removes any mention of the prelude environment and updates any reference to it correctly
  • Revamp dummy binding behavior, it now depends on the objects in the heap of each environment
  • Refactored some code to better match the new behavior
  • Round values returned by getTextWidth so test cases do not have floating point irregularities

Problems

  • Any arrays or closures created from calling stream_tail may not have the correct environment, there is a workaround present but the results may be unexpected
    • This is due to stream_tail being a built-in function, a future js-slang version might change this

@coveralls
Copy link

coveralls commented Mar 28, 2024

Pull Request Test Coverage Report for Build 8480401789

Details

  • 163 of 175 (93.14%) changed or added relevant lines in 13 files are covered.
  • 11 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.3%) to 35.544%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/features/cseMachine/components/values/FnValue.tsx 13 14 92.86%
src/features/cseMachine/components/values/PrimitiveValue.tsx 7 8 87.5%
src/features/cseMachine/CseMachineUtils.ts 41 43 95.35%
src/features/cseMachine/CseMachineLayout.tsx 59 63 93.65%
src/features/cseMachine/components/values/UnassignedValue.tsx 5 9 55.56%
Files with Coverage Reduction New Missed Lines %
src/features/cseMachine/components/values/UnassignedValue.tsx 1 63.16%
src/features/cseMachine/CseMachineLayout.tsx 2 66.77%
src/features/cseMachine/components/Binding.tsx 3 88.89%
src/features/cseMachine/components/arrows/ArrowFromText.tsx 5 44.0%
Totals Coverage Status
Change from base Build 8480300677: 0.3%
Covered Lines: 5174
Relevant Lines: 13605

💛 - Coveralls

@RichDom2185 RichDom2185 mentioned this pull request Mar 28, 2024
5 tasks
Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have the time to review this, but to not block the breaking changes for the development teams, let's merge it first since CI is passing.

@martin-henz martin-henz merged commit ef6c172 into master Mar 29, 2024
8 checks passed
@martin-henz martin-henz deleted the 1055 branch March 29, 2024 12:57
izruff pushed a commit that referenced this pull request Apr 2, 2024
* Frontend changes for js-slang PR #1600

* bumping js-slang

* Update tests, workaround `stream_tail` problems

* Formatting

* Update comment

---------

Co-authored-by: CZX <CZX123@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
4 participants