Skip to content

Grading Overview - Clickable Horizontal Scrollbar #2824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

InfinityTwo
Copy link
Contributor

@InfinityTwo InfinityTwo commented Feb 26, 2024

Description

Resolves #2816.

The fix is a little hacky as it's not really possible to add a style or className to the Tremor UI's Footer component to style it. Due to how Footer is implemented in Tremor UI, where it sticks to the bottom of the parent element, and blocks the scrollbar, it's basically impossible (at least to my knowledge) to make the scrollbar clickable without directly/indirectly styling the Footer. However, if we update Tremor UI to the later versions, they do support adding style and className, which would allow the fix to be less hacky.

As for the commit history, just note that only commits from 7a8849d are relevant, the rest before have been merged.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

How to test

  • Open Grading page
  • Make sure there's some things in the table
  • Make your window horizontally smaller if it's too large
  • Click and drag the scrollbar

Checklist

  • I have tested this code
  • I have updated the documentation

@InfinityTwo InfinityTwo self-assigned this Feb 26, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8052496519

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 37.948%

Totals Coverage Status
Change from base Build 8050128878: 0.0%
Covered Lines: 5811
Relevant Lines: 14370

💛 - Coveralls

Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! As mentioned in the previous PR, I think these hacky approaches are fine for now since we plan to move out of Tremor.

@RichDom2185 RichDom2185 merged commit 36e6352 into source-academy:master Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grading UI/UX: Unclickable Horizontal Scrollbar
4 participants