Skip to content

Game: Remove Object Placement feature from Game Simulator #2810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

lhw-1
Copy link
Collaborator

@lhw-1 lhw-1 commented Feb 23, 2024

Description

Partially addresses #2806. This PR will be in draft for now until we have finalized the decision to remove the Object Placement feature.

This PR removes the Object Placement feature completely from the Game Simulator. As discussed in the linked issue, the Object Placement feature is currently not in use by the story-writers (myself), and is inaccessible to the students. Hence, there are no active users, and may need to be retired.

While there certainly is potential for the Object Placement feature to play a role in the future (e.g. being able to generate completely new asset combinations for the game and the CMR feature), it can be retired for now, and we can re-implement it with only the necessary features when needed.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

This would be considered breaking change by definition; however, the rest of the Game Simulator is quite independent from the Object Placement feature, and the removal of this feature should not cause any major changes to the other functionalities.

How to test

Build and deploy the frontend, and check that all other functionalities continue to work as expected.

Checklist

  • I have tested this code
  • I have updated the documentation

@coveralls
Copy link

coveralls commented Feb 23, 2024

Pull Request Test Coverage Report for Build 8029216306

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.7%) to 37.948%

Totals Coverage Status
Change from base Build 8029208794: 0.7%
Covered Lines: 5811
Relevant Lines: 14370

💛 - Coveralls

Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks goods, I don't see why there's a need to keep it if you really think it's not of use. I'll approve this and feel free to merge if you want to.

@lhw-1 lhw-1 marked this pull request as ready for review February 24, 2024 09:24
@lhw-1 lhw-1 merged commit 519ceba into source-academy:master Feb 24, 2024
@lhw-1 lhw-1 deleted the gamesimulator/remove-object-placement branch March 19, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants