Skip to content

Migrate to Redux Toolkit part 2 #2789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Feb 23, 2024
Merged

Migrate to Redux Toolkit part 2 #2789

merged 15 commits into from
Feb 23, 2024

Conversation

RichDom2185
Copy link
Member

@RichDom2185 RichDom2185 commented Feb 18, 2024 •
edited
Loading

Description

To rebase and force-push following the merge of #2758.

Also fixes a small type issue.

Please refer to commit history for list of changes, linked PR for motivation of changes.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

How to test

Checklist

  • I have tested this code
  • I have updated the documentation

@RichDom2185 RichDom2185 self-assigned this Feb 18, 2024
@RichDom2185
Prepare workspace reducer for RTK migration
74eb012 
Splits it into three components:

* Old reducer
* New (blank) reducer
* Exported reducer which includes special handling for sourcecast and
  sourcereel actions, before attempting to call the other two reducers
@RichDom2185
Migrate BROWSE_REPL_HISTORY_DOWN to new reducer
4d366c4
@RichDom2185
Migrate BROWSE_REPL_HISTORY_UP to new reducer
32a6d8f
@RichDom2185
Migrate more reducers to new reducer
e389b6a 
Migrated the reducers for the following action types:

* `CHANGE_EXEC_TIME`
* `CHANGE_SIDE_CONTENT_HEIGHT`
* `CHANGE_STEP_LIMIT`
* `CLEAR_REPL_INPUT`
* `CLEAR_REPL_OUTPUT_LAST`
* `CLEAR_REPL_OUTPUT`
@RichDom2185
Simplify workspace reducer test generation code
b7704dc
@coveralls
Copy link

coveralls commented Feb 21, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8023395449

Details

  • -7 of 69 (89.86%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.009%) to 37.182%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/features/playground/PlaygroundActions.ts 8 9 88.89%
src/features/sourceRecorder/sourcereel/SourcereelActions.ts 12 14 85.71%
src/commons/workspace/WorkspaceReducer.ts 40 44 90.91%
Totals Coverage Status
Change from base Build 8023315459: 0.009%
Covered Lines: 5807
Relevant Lines: 14688
💛 - Coveralls

@RichDom2185
Reformat workspace reducer tests
75397c0 
Reduces unnecessary whitespace for better readability.
@RichDom2185
Migrate playground actions to RTK
bfd8d44
@RichDom2185
Refactor main saga
50cf390 
Uses the `all` function to combine multiple sagas together. This will
facilitate future potential refactoring where sagas may be conditionally
run.
@RichDom2185
Fix workspace actions typing
bfcc4c6
@RichDom2185
Merge branch 'master' into rtk-2
2a0bc9b
@RichDom2185
Merge branch 'master' into rtk-2
7add399
@RichDom2185 RichDom2185 marked this pull request as ready for review February 23, 2024 15:39
RichDom2185
RichDom2185 commented Feb 23, 2024
View reviewed changes
Copy link
Member Author

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we can merge to test the compatibility between the old and new systems before undergoing further changes.

@RichDom2185 RichDom2185 merged commit dcd2c69 into master Feb 23, 2024
@RichDom2185 RichDom2185 deleted the rtk-2 branch February 23, 2024 18:34
@RichDom2185 RichDom2185 mentioned this pull request Feb 24, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sayomaki sayomaki Awaiting requested review from sayomaki

@chownces chownces Awaiting requested review from chownces

Assignees

@RichDom2185 RichDom2185

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RichDom2185 @coveralls