Skip to content

Update dependency eslint-plugin-simple-import-sort to v12 #2771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Feb 11, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
eslint-plugin-simple-import-sort ^11.0.0 -> ^12.0.0 age adoption passing confidence

Release Notes

lydell/eslint-plugin-simple-import-sort (eslint-plugin-simple-import-sort)

v12.0.0

Compare Source

This release removes the support for import assignments added in version 11.0.0:

  • Turns out it was broken in some cases.
  • The suggested fix went past my complexity tolerance for such an esoteric feature.
  • I also learned that they aren’t really imports, and that I don’t understand their semantics well enough to know how sorting them affects your program.

If you miss the support for import assignments, I suggest you write your own ESLint rule which moves them out of the way from the actual imports, sorting them or not.


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the dependencies This pull request updates dependency files label Feb 11, 2024
@RichDom2185 RichDom2185 enabled auto-merge (squash) February 11, 2024 14:53
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7862755508

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 37.204%

Totals Coverage Status
Change from base Build 7841630699: 0.0%
Covered Lines: 5723
Relevant Lines: 14458

💛 - Coveralls

@RichDom2185 RichDom2185 merged commit a5170f4 into master Feb 11, 2024
@RichDom2185 RichDom2185 deleted the renovate/eslint-plugin-simple-import-sort-12.x branch February 11, 2024 14:59
InfinityTwo pushed a commit to InfinityTwo/sourceacademy-frontend that referenced this pull request Feb 12, 2024
…demy#2771)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies This pull request updates dependency files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants