Skip to content

Enable Stepper for Typed Variant #2766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 9, 2024
Merged

Enable Stepper for Typed Variant #2766

merged 4 commits into from
Feb 9, 2024

Conversation

Zenkoh1
Copy link
Contributor

@Zenkoh1 Zenkoh1 commented Feb 8, 2024 •
edited
Loading

Description

Progressively roll out features of Source (Stepper tool) for its Typed Variant.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Code quality improvements

How to test

The stepper tool will be enabled for the Typed Variant of Source, for Source §1 and Source §2.

Checklist

  • I have tested this code

RichDom2185
RichDom2185 previously approved these changes Feb 8, 2024
View reviewed changes
@RichDom2185 RichDom2185 enabled auto-merge (squash) February 8, 2024 21:07
@RichDom2185 RichDom2185 disabled auto-merge February 8, 2024 21:18
@RichDom2185 RichDom2185 dismissed their stale review February 8, 2024 21:18

CI (test) fail

@RichDom2185
Copy link
Member

Hi, please update the test snapshots, thanks! Consider it practice for future PRs to check that yarn format and yarn test both pass successfully :)

@coveralls
Copy link

coveralls commented Feb 9, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7841543283

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 37.204%
Totals Coverage Status
Change from base Build 7841365654: 0.002%
Covered Lines: 5723
Relevant Lines: 14458
💛 - Coveralls

RichDom2185
RichDom2185 approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@RichDom2185 RichDom2185 merged commit 60381e0 into master Feb 9, 2024
@RichDom2185 RichDom2185 deleted the enable-stepper-typed-variant branch February 9, 2024 08:49
InfinityTwo pushed a commit to InfinityTwo/sourceacademy-frontend that referenced this pull request Feb 12, 2024
@Zenkoh1 @RichDom2185 @InfinityTwo
Enable Stepper for Typed Variant (source-academy#2766)
e01c64f 
* Enable Stepper for Typed Variant

* Fix format

* Modify CI tests, enabling Stepper tool for Typed Variant

---------

Co-authored-by: Richard Dominick <34370238+RichDom2185@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RichDom2185 RichDom2185 RichDom2185 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zenkoh1 @RichDom2185 @coveralls