Upgrade to Blueprint v5 #2718
Merged
Upgrade to Blueprint v5 #2718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Done as per migration guide.
Fixes a compile error following the version upgrade.
Resolves the issue with the deprecated `DateInput` component. Also made the necessary API changes for the migration.
Fixes the breaking change introduced by the Blueprint v5 upgrade.
|
Despite no more compile errors, there are still some UI regressions, thus I'm keeping this PR as draft for now. |
Do you recall what are the UI regressions here? |
Yes, some tables/styles look wrong. I believe they might be because of conflicts with our custom stylesheets, but I have yet to look into them in more detail. Though notably, the date/time picker component has been revamped in v5, so the UX there suffered a lot too (though I believe functionality still works). |
…y-frontend into upgrade-to-blueprint-v5
…y-frontend into upgrade-to-blueprint-v5
Update the target classes to match the new components.
Pull Request Test Coverage Report for Build 7862853337
💛 - Coveralls |
sayomaki
approved these changes
Feb 12, 2024
6 tasks
InfinityTwo
pushed a commit
to InfinityTwo/sourceacademy-frontend
that referenced
this pull request
Feb 12, 2024
* Replace deprecated `ITreeNode` with `TreeNodeInfo` Done as per migration guide. * Upgrade BlueprintJS dependencies to v5 * Use public `IconName` type instead of internal API Fixes a compile error following the version upgrade. * Migrate to `Datetime2` package Resolves the issue with the deprecated `DateInput` component. Also made the necessary API changes for the migration. * Update prop name Fixes the breaking change introduced by the Blueprint v5 upgrade. * Update test snapshots * Reran `yarn install` post-merge * Update snapshots post-merge * Update SCSS namespace * Fix popover styles Update the target classes to match the new components. * Revert Env Vizualiser snapshot change * Fix TreeNode comparison to compare id instead of object reference --------- Co-authored-by: sayomaki <sayomayomaki@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrades the version of BlueprintJS and related dependencies to v5 to future-proof the platform.
Type of change
How to test
All components work and look correct.
Checklist