Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor improvements in env viz #2677

Merged
merged 9 commits into from
Sep 18, 2023
Merged

minor improvements in env viz #2677

merged 9 commits into from
Sep 18, 2023

Conversation

martin-henz
Copy link
Member

@martin-henz martin-henz commented Sep 17, 2023 •
edited
Loading

  • remove no-longer-existing instruction PUSH_UNDEFINED_IF_NEEDED
  • minor improvements and typos in env viz UI
  • renaming of instructions
  • lower case instructions in agenda
  • adding number of arguments to APPLICATION instruction (now called "call")

@martin-henz martin-henz marked this pull request as draft September 17, 2023 14:44
@coveralls
Copy link

coveralls commented Sep 17, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6214835507

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.002%) to 37.292%
Files with Coverage Reduction New Missed Lines %
src/features/envVisualizer/EnvVisualizerUtils.ts 1 68.39%
Totals Coverage Status
Change from base Build 6155012554: -0.002%
Covered Lines: 5709
Relevant Lines: 14394
💛 - Coveralls

@martin-henz martin-henz marked this pull request as ready for review September 17, 2023 16:36
vansh284
vansh284 approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@vansh284 vansh284 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@martin-henz martin-henz merged commit 4d54fc8 into master Sep 18, 2023
@martin-henz martin-henz deleted the env_viz_77 branch September 18, 2023 05:09
RichDom2185 pushed a commit to NUS-CS1101S/cadet-frontend that referenced this pull request Oct 5, 2023
@martin-henz @vansh284 @RichDom2185
minor improvements in env viz (source-academy#2677)
81f9d98 
* minor improvements in env viz

* updating snapshots

* Update snapshots

* bumping js-slang

* bumping js-slang

* Update snapshots

* minor improvements

* Update snapshots

---------

Co-authored-by: vansh284 <vanshnath284@gmail.com>
RichDom2185 pushed a commit to NUS-CS1101S/cadet-frontend that referenced this pull request Oct 5, 2023
@martin-henz @vansh284 @RichDom2185
minor improvements in env viz (source-academy#2677)
ff86dc4 
* minor improvements in env viz

* updating snapshots

* Update snapshots

* bumping js-slang

* bumping js-slang

* Update snapshots

* minor improvements

* Update snapshots

---------

Co-authored-by: vansh284 <vanshnath284@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vansh284 vansh284 vansh284 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martin-henz @coveralls @vansh284