Skip to content

Add on_finish field to assessments #1239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Mar 31, 2025
Merged

Add on_finish field to assessments #1239

merged 15 commits into from
Mar 31, 2025

Conversation

JustATin555
Copy link
Contributor

@JustATin555 JustATin555 commented Mar 19, 2025 •
edited by RichDom2185
Loading

  • Added is_minigame string field to AssessmentsConfig
  • Added isMinigame field to JSON api

Requires all users to migrate with mix ecto.migrate
Should be used in conjunction with source-academy/frontend#3105

@JustATin555 JustATin555 self-assigned this Mar 19, 2025
@JustATin555 JustATin555 added the _frontend The issue concerns frontend component label Mar 19, 2025
@coveralls
Copy link

coveralls commented Mar 19, 2025 •
edited
Loading

Coverage Status

coverage: 93.607% (+0.002%) from 93.605%
when pulling da13afc on assessment-finish-submit
into 41e3ce1 on master.

@JustATin555 JustATin555 marked this pull request as draft March 20, 2025 06:30
@JustATin555 JustATin555 marked this pull request as ready for review March 27, 2025 02:16
@JustATin555 JustATin555 requested a review from RichDom2185 March 27, 2025 02:23
@GabrielCWT GabrielCWT marked this pull request as draft March 27, 2025 06:50
@GabrielCWT
Copy link
Contributor

Discussed with @JustATin555, this should be moved to assessment config instead of in assessment

@JustATin555 JustATin555 marked this pull request as ready for review March 30, 2025 11:59
@JustATin555 JustATin555 requested a review from GabrielCWT March 30, 2025 11:59
GabrielCWT
GabrielCWT requested changes Mar 31, 2025
View reviewed changes
@JustATin555 JustATin555 requested a review from GabrielCWT March 31, 2025 04:41
RichDom2185
RichDom2185 approved these changes Mar 31, 2025
View reviewed changes
Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Will merge since it's not a blocker for the frontend PR

@RichDom2185 RichDom2185 merged commit 5c7b5cf into master Mar 31, 2025
2 checks passed
@RichDom2185 RichDom2185 deleted the assessment-finish-submit branch March 31, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RichDom2185 RichDom2185 RichDom2185 approved these changes

@GabrielCWT GabrielCWT GabrielCWT approved these changes

Assignees

@JustATin555 JustATin555

Labels
_frontend The issue concerns frontend component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JustATin555 @coveralls @GabrielCWT @RichDom2185