Rename contest leaderboard to score leaderboard #1064
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation of new feature which shows contest leaderboard based on votes
3 tasks
Member
|
Corresponding frontend PR: source-academy/frontend#2779 |
RichDom2185
approved these changes
Feb 13, 2024
Member
RichDom2185
left a comment
RichDom2185
left a comment
There was a problem hiding this comment.
LGTM, we only need to change the view layer (as done in this PR) – I don't think we need to change the model layer. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the type of the JSON returned from contestLeaderboard to scoreLeaderboard in order to accompany the changes in Frontend.
Type of change