Scaling retina coordinates for all callbacks #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously only the `.draw` callback had it's coodinate system scaled, when in retina land. This meant that the coordinate system was inconsistent between, for example, `.draw` and `.update`. This fix adds scaling to `.update` and all other callbacks (such as `mouseover`, `click`, ...).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this pull request, when in "retina land", only the
drawcallback and no other had its coordinate system scaled. This means that coordinates were inconsistent betweendrawandsketch.mouseon the one hand and all other callbacks (such asupdateandtouchmove) on the other.In this pull request I moved the execution of
updateto also be affected by thedrawscaling. Furthermore I added a scaling wrapper around all other callbacks. I also removed my previous pull request which "fixes" the mouse retina coordinates for all "other" callbacks, but inconveniently breaks it fordraw.All changes affect only
retina: truescenes.Please let me know if you had another solution in mind or anything is unclear, I am happy to adjust this pull request to whatever fits the project. Thanks!