Drop PHP-CS-Fixer 1.x support #34
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soullivaneuh
force-pushed
the
cs-fixer-1.x-drop
branch
3 times, most recently
from
28614be to
1635f6e
Compare
soullivaneuh
force-pushed
the
cs-fixer-1.x-drop
branch
from
1635f6e to
ea8f605
Compare
| - php: 5.6 | ||
| env: PHP_CS_FIXER_VERSION=2.*@dev | ||
| env: PHP_CS_FIXER_VERSION=3.*@dev |
There was a problem hiding this comment.
not sure there will be a 3.x for a long time
There was a problem hiding this comment.
i doubt the master will become 3.x
There was a problem hiding this comment.
Well, I'll not merge this PR very soon, this is just a preparation.
Let's see what it will be done when php-cs-fixer will be stable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #31.
ConfigBridge::getFixers. Move stuff onConfigBridge::getRules.ConfigBridge::getLevelhas no need to be removed as it's already done on #33.Note: Make a new major branch for 2.x before merging this one.