Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog links not working #104

Closed
Sir-Cumference opened this issue Aug 30, 2016 · 7 comments · Fixed by #110
Closed

Blog links not working #104

Sir-Cumference opened this issue Aug 30, 2016 · 7 comments · Fixed by #110
Assignees
Milestone

Comments

@Sir-Cumference
Copy link
Collaborator

Installed Version: 1.X.X Environment: Chrome/Tampermonkey

2.0.1G
...

Expected Behavior

When I go to the menu and hover over a site, a blog link will appear. That link will take me to the blog for the site.
...

Actual Behavior

Two problems:

  1. The blog link appears, but it pretty much only takes me to blog.stackexchange.com, instead of the specific blog for the site.

  2. Mathematics seems to work, but introduces a second problem. If I hover over the blog button for the Mathematics SE, and then click on the link to another site's blog, it will direct me to math.blogoverflow.com.
    ...

SOX Errors logged to the browser console (if available)

...

Steps to reproduce

First problem:

  1. Open the Stack Exchange menu (top-left)
  2. Click on any of the links to the blogs, and notice that you are taken to the StackOverflow blog.

Second problem:

  1. Open the Stack Exchange menu (top-left)
  2. Hover over the blog link for Mathematics SE, but do not click on it
  3. Click on the blog links for any other site, and notice that you are taken to Math SE's blog.
@shu8
Copy link
Member

shu8 commented Aug 30, 2016

Hi again! Thanks for posting this bug! I remember coming across this bug a while back and completely forgot about it. I have (re-)reproduced this. Hopefully, this will be fixed by v2.0.2 at the latest. I'll keep you posted on the progress of the fix :)

@shu8 shu8 added this to the v2.0.2 milestone Aug 30, 2016
@shu8 shu8 self-assigned this Aug 30, 2016
@shu8 shu8 modified the milestones: v2.0.1, v2.0.2 Aug 30, 2016
@shu8
Copy link
Member

shu8 commented Oct 1, 2016

@IStoleThePies Sorry for such a long wait, but this should be fixed now in v2.0.1m -- the issue was that not all sites have blogs, so the script made the URL for any sites which did have a blog, but never changed the variable if they didn't, so it stuck with any non-blog sites :/

Please could you try installing it from this link and confirm it is working (or not)? :) Thanks!

@shu8 shu8 added ready and removed in progress labels Oct 1, 2016
shu8 pushed a commit that referenced this issue Oct 1, 2016
@Sir-Cumference
Copy link
Collaborator Author

Sir-Cumference commented Oct 1, 2016

@shu8 The chat links work perfectly, but the blog links are still very glitchy.
Sometimes they might just send me to the page I'm currently on; other
times they may send me to completely different SE sites.

I'd also like to mention that blogs were discontinued a few years ago: https://meta.stackexchange.com/questions/244467/were-no-longer-starting-new-individual-site-community-blogs-heres-why

The sites that made blogs before they were discontinued can still update them,
but almost all SE sites don't have blogs, nor can they make them.

EDIT: You can see the list of sites with blogs here: https://stackexchange.com/blogs

@shu8
Copy link
Member

shu8 commented Oct 1, 2016

@IStoleThePies hmm, I was totally unaware that sites could no longer make new blogs!

TBH that kind of makes me think how useful the blog link really is, if it will only ever work on 20-or-odd sites, most of which haven't had new posts in quite a while.

Quick question: have you ever used the blog link? (I'm thinking of just getting rid of the blog link and keeping the chat one...)

@Sir-Cumference
Copy link
Collaborator Author

@shu8 To be honest, I was never active on a site that used blogs. I had only learned about them from sox. That said, out of the 24 sites that use it, only five have actually updated in this past year, and only Science Fiction & Fantasy is regularly active (one new blog post per week). I'd probably vote on removing them, since they are almost abandoned.

@shu8
Copy link
Member

shu8 commented Oct 1, 2016

@IStoleThePies yep, looks like I'll just get rid of it -- it's easier for me :P

shu8 pushed a commit that referenced this issue Oct 1, 2016
@shu8
Copy link
Member

shu8 commented Oct 1, 2016

Removed the blog link in v2.0.1n

@shu8 shu8 closed this as completed Oct 1, 2016
@shu8 shu8 removed the ready label Oct 1, 2016
shu8 added a commit that referenced this issue Oct 1, 2016
* Update README.md

* changes

* don't use stack.read if not available

* fixes script on Firefox hopefully

should fix #75, #76, #71

* fixes #73

* bump version

* fixes some bugs

fixes:
- #89,
- #95,
- bug relating to #98
- change to #88
- fixes SBS (part of #72)
- fixes #80 and part of #72
- fixes #72 entirely
- fixes compatibility issue between SBS and enhanced editor features

* changes

#72, #98, #73

* fixes

- fixes #72
- should fix #98
- added logs for #73

* #93

* #73

* #95

* #75, #95

* clean-up, add debugging for #98

* add debugging for #98, cleanup

* #73

* #73, #102

* #102

* #98

* 2.0.1i

* #98

* #95

* #98

* fixes #104, #105

* fixes #103, changes to #104

* v2.0.1 final
@shu8 shu8 mentioned this issue Oct 1, 2016
shu8 added a commit that referenced this issue Oct 1, 2016
* Update README.md

* changes

* don't use stack.read if not available

* fixes script on Firefox hopefully

should fix #75, #76, #71

* fixes #73

* bump version

* fixes some bugs

fixes:
- #89,
- #95,
- bug relating to #98
- change to #88
- fixes SBS (part of #72)
- fixes #80 and part of #72
- fixes #72 entirely
- fixes compatibility issue between SBS and enhanced editor features

* changes

#72, #98, #73

* fixes

- fixes #72
- should fix #98
- added logs for #73

* #93

* #73

* #95

* #75, #95

* clean-up, add debugging for #98

* add debugging for #98, cleanup

* #73

* #73, #102

* #102

* #98

* 2.0.1i

* #98

* #95

* #98

* fixes #104, #105

* fixes #103, changes to #104

* v2.0.1 final
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants